Skip to content

[php-nextgen] Rename folders to follow PDS skeleton#15102

Merged
wing328 merged 2 commits intoOpenAPITools:php-nextgenfrom
ybelenko:php-nextgen-pds-skeleton
Apr 4, 2023
Merged

[php-nextgen] Rename folders to follow PDS skeleton#15102
wing328 merged 2 commits intoOpenAPITools:php-nextgenfrom
ybelenko:php-nextgen-pds-skeleton

Conversation

@ybelenko
Copy link
Copy Markdown
Contributor

@ybelenko ybelenko commented Apr 1, 2023

I swapped test and tests folders to follow PDS skeleton
Ref: https://github.com/php-pds/skeleton

$  vendor/bin/phpunit
PHPUnit 9.6.5 by Sebastian Bergmann and contributors.

IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII  63 / 213 ( 29%)
IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII 126 / 213 ( 59%)
IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII 189 / 213 ( 88%)
IIIIIIIIIIIIIIIIIIIIIIII                                        213 / 213 (100%)

Time: 00:00.334, Memory: 20.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 213, Assertions: 0, Incomplete: 213.

cc @Articus @jebentier @dkarlovi @mandrean @jfastnacht @renepardon

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ybelenko ybelenko changed the title [php] Change folders to follow PDS skeleton [php] Rename folders to follow PDS skeleton Apr 3, 2023
@wing328 wing328 changed the title [php] Rename folders to follow PDS skeleton [php-nextgen] Rename folders to follow PDS skeleton Apr 4, 2023
@wing328 wing328 added this to the 6.6.0 milestone Apr 4, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 4, 2023

thanks for the PR

please use [php-nextgen] instead of [php] in the subject line moving forward for changes related to php-nextgen client generator.

@wing328 wing328 merged commit 54406d3 into OpenAPITools:php-nextgen Apr 4, 2023
@ybelenko ybelenko deleted the php-nextgen-pds-skeleton branch April 7, 2023 06:30
wing328 added a commit that referenced this pull request Sep 3, 2023
* php-nextgen first commit

* [php] Set minimal PHP version to ^8.0 (#14500)

* Set minimal PHP version to ^8.0

* Fix php-nextgen config

* Change stability to BETA

* Add phplint package (#15054)

* [php-nextgen] Rename folders to follow PDS skeleton (#15102)

* Change lib -> src, test -> tests folder

This will make build compliant to PHP-PDS skeleton.
Ref: https://github.com/php-pds/skeleton

* Refresh samples

* Exclude composer.lock from codebase (#15105)

Since client generator is library and not a project it makes sense
to exclude composer.lock from codebase by default.

Ref: http://getcomposer.org/doc/02-libraries.md#lock-file

* Add @generated tag to DocBlocks (#15106)

This tag in draft status right now(PSR-19), but I think we can leverage
from it already.

Ref: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-generated

* update samples, doc

* update samples

---------

Co-authored-by: Yuriy Belenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants