Skip to content

[go] Fix: reservedWordsMappings not checked for reserved word#15083

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
lwj5:reserve
Apr 11, 2023
Merged

[go] Fix: reservedWordsMappings not checked for reserved word#15083
wing328 merged 2 commits intoOpenAPITools:masterfrom
lwj5:reserve

Conversation

@lwj5
Copy link
Copy Markdown
Contributor

@lwj5 lwj5 commented Mar 31, 2023

Using --reserved-words-mappings argument does not work they are not marked to be escaped

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Fixes

Partially addresses #14956

@lwj5 lwj5 changed the title Fix: reservedWordsMappings not checked for reserved word [go] Fix: reservedWordsMappings not checked for reserved word Mar 31, 2023
@lwj5
Copy link
Copy Markdown
Contributor Author

lwj5 commented Mar 31, 2023

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

simple few liner PR, please help review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Go][Ability to specify different field name than JSON derived one [BUG][Go] respect initialisms or acronyms in names

2 participants