Skip to content

[csharp] Use string literals for default string values#15049

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
devhl-labs:15031-literal-string-default
Apr 1, 2023
Merged

[csharp] Use string literals for default string values#15049
wing328 merged 1 commit intoOpenAPITools:masterfrom
devhl-labs:15031-literal-string-default

Conversation

@devhl-labs
Copy link
Copy Markdown
Contributor

Fixes #15031

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 6.5.0 milestone Apr 1, 2023
@wing328 wing328 merged commit c838b1d into OpenAPITools:master Apr 1, 2023
@devhl-labs devhl-labs deleted the 15031-literal-string-default branch April 1, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] All csharp generators incorrectly render default strings containing e.g. backslashes due to incorrect unescaping

2 participants