Skip to content

[Elixir] fix ":body" handling#1504

Merged
wing328 merged 6 commits intomasterfrom
elixir_body_param
Nov 28, 2018
Merged

[Elixir] fix ":body" handling#1504
wing328 merged 6 commits intomasterfrom
elixir_body_param

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 20, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

When JSON payload needs to be in the body ("in": "body"), it must not generate a multi-part body, but embed directly in HTTP body.

cc @chgeuer

chgeuer and others added 2 commits November 20, 2018 21:30
…en#8138

When JSON payload needs to be in the body (`"in": "body"`), it must not generate a multi-part body, but embed directly in HTTP body.
@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Nov 28, 2018

@chgeuer FYI. We've made a slight change based on the feedback by @mrmstn to remove double quote around body to get rid of the following warning:

warning: found quoted atom "body" but the quotes are not required. Quotes should only be used to introduce atoms with foreign characters in them

@wing328 wing328 merged commit c63f58f into master Nov 28, 2018
@wing328 wing328 deleted the elixir_body_param branch November 28, 2018 13:36
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Fix swagger-api/swagger-codegen/issues/8138 swagger-api/swagger-codegen#8138

When JSON payload needs to be in the body (`"in": "body"`), it must not generate a multi-part body, but embed directly in HTTP body.

* update elixir samples

* update elixir client samples

* remove double quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants