[java][Jersey2/3] Probe content type for multipart upload parts#14965
Merged
wing328 merged 6 commits intoOpenAPITools:masterfrom Apr 14, 2023
Merged
[java][Jersey2/3] Probe content type for multipart upload parts#14965wing328 merged 6 commits intoOpenAPITools:masterfrom
wing328 merged 6 commits intoOpenAPITools:masterfrom
Conversation
…ire each part to correctly identify its type.
Contributor
Author
|
I notice some tests failed, and it seems related (because it's mentioning an upload of a .png as the last log line) but as far as I can tell, it's not related (since it's in the Typescript test suite). |
wing328
reviewed
Apr 13, 2023
Member
|
can you please update the samples when you've time? |
Contributor
Author
OK I've done that and it looks like all the checks passed. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many servers throw errors if the multipart upload doesn't correctly identify the part. If a file is passed in to be uploaded, we can use NIO APIs to probe the content type more specifically. In the case of any error, we fall back to the previous default
MediaType.APPLICATION_OCTET_STREAM_TYPE.@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)