Skip to content

Better warning message and default value#1492

Merged
wing328 merged 1 commit intomasterfrom
fix-warning
Nov 19, 2018
Merged

Better warning message and default value#1492
wing328 merged 1 commit intomasterfrom
fix-warning

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 19, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Better warning message when missing host or servers
  • Better default value for the project description in JS client generator

@wing328 wing328 added this to the 3.3.4 milestone Nov 19, 2018
@wing328 wing328 merged commit 363b095 into master Nov 19, 2018
@wing328 wing328 deleted the fix-warning branch November 19, 2018 12:55
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant