Skip to content

Fix NPE in the C# Nancy generator#1478

Merged
jimschubert merged 1 commit intomasterfrom
fix_npe_nancyfx
Nov 17, 2018
Merged

Fix NPE in the C# Nancy generator#1478
jimschubert merged 1 commit intomasterfrom
fix_npe_nancyfx

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 17, 2018 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix the following NPE:

[main] WARN  o.o.codegen.utils.ModelUtils - Multiple schemas found, returning only the first one
[main] INFO  o.o.codegen.DefaultGenerator - Model periodicPaymentInitiationMultipartBody (marked as unused due to form parameters) is generated due to skipFormModel=false (default)
[main] INFO  o.o.codegen.DefaultGenerator - Model periodicPaymentInitiation_xml-Part2-standingorderType_json (marked as unused due to form parameters) is generated due to skipFormModel=false (default)
Exception in thread "main" java.lang.NullPointerException
	at org.openapitools.codegen.languages.CSharpNancyFXServerCodegen.postProcessParentModels(CSharpNancyFXServerCodegen.java:288)
	at org.openapitools.codegen.languages.CSharpNancyFXServerCodegen.postProcessAllModels(CSharpNancyFXServerCodegen.java:280)
	at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:439)
	at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:865)
	at org.openapitools.codegen.cmd.Generate.run(Generate.java:349)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:62)

cc @mandrean (2017/08) @jimschubert (2017/09)

@wing328 wing328 added this to the 3.3.4 milestone Nov 17, 2018
@jimschubert jimschubert merged commit 941b3ea into master Nov 17, 2018
@jimschubert
Copy link
Copy Markdown
Member

jimschubert commented Nov 17, 2018

Thanks!

@jimschubert jimschubert deleted the fix_npe_nancyfx branch November 17, 2018 15:11
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@wing328 @jimschubert
fix NPE in the C# Nancy generator (OpenAPITools#1478)
fa08eb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimschubert jimschubert jimschubert approved these changes

Assignees

No one assigned

Labels

Issue: Bug Server: C-Sharp

Projects

None yet

Milestone

3.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@wing328 @jimschubert