Skip to content

Fix NPE with cpp-restsdk client generator#1477

Merged
wing328 merged 2 commits intomasterfrom
fix_cpp_rest_sdk
Nov 19, 2018
Merged

Fix NPE with cpp-restsdk client generator#1477
wing328 merged 2 commits intomasterfrom
fix_cpp_rest_sdk

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 17, 2018 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix the following NPE:

[main] WARN  o.o.codegen.utils.ModelUtils - Multiple schemas found, returning only the first one
[main] WARN  o.o.codegen.utils.ModelUtils - Multiple schemas found, returning only the first one
[main] INFO  o.o.codegen.DefaultGenerator - Model periodicPaymentInitiationMultipartBody (marked as unused due to form parameters) is generated due to skipFormModel=false (default)
[main] INFO  o.o.codegen.DefaultGenerator - Model periodicPaymentInitiation_xml-Part2-standingorderType_json (marked as unused due to form parameters) is generated due to skipFormModel=false (default)
Exception in thread "main" java.lang.NullPointerException
	at org.openapitools.codegen.languages.CppRestSdkClientCodegen.processParentPropertiesInChildModel(CppRestSdkClientCodegen.java:438)
	at org.openapitools.codegen.languages.CppRestSdkClientCodegen.postProcessParentModels(CppRestSdkClientCodegen.java:425)
	at org.openapitools.codegen.languages.CppRestSdkClientCodegen.postProcessAllModels(CppRestSdkClientCodegen.java:416)
	at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:439)
	at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:865)
	at org.openapitools.codegen.cmd.Generate.run(Generate.java:349)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:62)

cc @ravinikam (2017/07) @stkrwork (2017/07) @fvarose (2017/11) @etherealjoy (2018/02) @MartinDelille (2018/03)

@wing328 wing328 added this to the 3.3.4 milestone Nov 17, 2018
@wing328 wing328 merged commit 0e693cd into master Nov 19, 2018
@wing328 wing328 deleted the fix_cpp_rest_sdk branch November 19, 2018 03:06
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@wing328
Fix NPE with cpp-restsdk client generator (OpenAPITools#1477)
17e70cc 
* fix_cpprest_npe

* fix_code_format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etherealjoy etherealjoy etherealjoy approved these changes

Assignees

No one assigned

Labels

Client: C++ Issue: Bug

Projects

None yet

Milestone

3.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@wing328 @etherealjoy