Skip to content

[JAVASCRIPT] Fix inconsistent validateJSON and validateJsonObject calls, breaking object validation.#14720

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
rignicat:validateJsonFix
Feb 16, 2023
Merged

[JAVASCRIPT] Fix inconsistent validateJSON and validateJsonObject calls, breaking object validation.#14720
wing328 merged 1 commit intoOpenAPITools:masterfrom
rignicat:validateJsonFix

Conversation

@rignicat
Copy link
Copy Markdown
Contributor

@rignicat rignicat commented Feb 16, 2023

I ran into this issue when using OpenAPI's 'anyof' structure. This issue exists in every generated model, but apparently the received responses aren't validated by default. For anyOf this validation was done, and this issue was uncovered. No github issue was made, since the fix is so simple.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @CodeNinjai @frol @cliffano

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 16, 2023

LGTM. Thanks for the PR.

@wing328 wing328 merged commit 9be92fa into OpenAPITools:master Feb 16, 2023
@rignicat rignicat deleted the validateJsonFix branch February 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants