Skip to content

ktor-client add toString() for generic params#14717

Merged
4brunu merged 2 commits intoOpenAPITools:masterfrom
Rattenkrieg:ktor-client-add-toString()-for-generic-params
Feb 17, 2023
Merged

ktor-client add toString() for generic params#14717
4brunu merged 2 commits intoOpenAPITools:masterfrom
Rattenkrieg:ktor-client-add-toString()-for-generic-params

Conversation

@Rattenkrieg
Copy link
Copy Markdown
Contributor

ktor-client doesn't support building form request from arbitrary parameters: it will happily consume values of predefined types such as String, Number etc but will fail in runtime (!) at a given line in case of say List<T> or Instant.
https://github.com/ktorio/ktor/blob/fb161cd7d268f2c0f62982d82d9264ca920173ad/ktor-client/ktor-client-core/common/src/io/ktor/client/request/forms/formDsl.kt#L63

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @wing328

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 16, 2023

cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

Copy link
Copy Markdown
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@4brunu 4brunu merged commit 9586099 into OpenAPITools:master Feb 17, 2023
@wing328 wing328 added this to the 6.4.0 milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants