[dart][dart-dio] Bump Dio to 5.0.0#14675
Conversation
a875f2b to
76eb025
Compare
76eb025 to
5fccaef
Compare
ahmednfwela
left a comment
There was a problem hiding this comment.
LGTM, there is just a small typo
|
|
|
that's great news, then we can just replace all |
We depend on LukaGiorgadze/http-mock-adapter#140 since we have tests using this package. |
5fccaef to
42a1ebb
Compare
| @@ -27,8 +27,8 @@ class Openapi { | |||
| this.dio = dio ?? | |||
| Dio(BaseOptions( | |||
There was a problem hiding this comment.
Now dio 5.0 will not imply the default content type, please ensure it's valid in requests.
There was a problem hiding this comment.
We have always manually set the content-type if it is specified in the spec. See https://github.com/OpenAPITools/openapi-generator/blob/master/samples/openapi3/client/petstore/dart-dio/petstore_client_lib_fake/lib/src/api/fake_api.dart#L147
There was a problem hiding this comment.
I think thats enough for now.
|
Tests are not running on min SDK due to https://github.com/lomsa-dev/http-mock-adapter/pull/140/files#r1104810809 |
|
This is ready I think, the Git test dependency can be switched to a released version later, it is pinned to a commit. |
1edcfce to
6d9d939
Compare
This PR updates the dart-dio generator to use
dio: ^5.0.0.Closes #14281
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)CC @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)