Skip to content

[python-nextgen] better datetime support in parameters#14621

Merged
wing328 merged 15 commits intomasterfrom
datetime-str
Feb 12, 2023
Merged

[python-nextgen] better datetime support in parameters#14621
wing328 merged 15 commits intomasterfrom
datetime-str

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Feb 5, 2023

  • add new option allowStringInDateTimeParameters
  • better datetime support in parameters by allowing both datetime and StrictStr via Union
  • add tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11) @spacether (2019/11) @krjakbrjak (2023/02)

@wing328 wing328 added this to the 6.4.0 milestone Feb 7, 2023
@wing328 wing328 marked this pull request as ready for review February 7, 2023 14:28
@wing328 wing328 requested a review from jimschubert as a code owner February 7, 2023 14:28
@wing328 wing328 merged commit 110460b into master Feb 12, 2023
@wing328 wing328 deleted the datetime-str branch February 12, 2023 13:11
@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Feb 19, 2023

Filed #14742 to improve the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant