Set proxy in ruby faraday client if configured#14597
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Feb 3, 2023
Merged
Set proxy in ruby faraday client if configured#14597wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
Specs now running properly: |
Member
|
thanks for the PR. can you please follow step 3 to update the samples so that the CI can verify the change? |
Contributor
Author
|
@wing328 thanks for the hint, looks like I ran into some problem with Java yesterday and didn't notice the error. Running it in docker did the trick. |
Member
|
@sled thanks for the PR, which has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relates to the bug reported in #14596 and configures the proxy for the Ruby Faraday client if a proxy is configured. It also adds a spec to ensure the proxy is set properly.
@cliffano @zlx @autopp
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)