[php-nextgen] Set minimal PHP version to ^8.0#14500
Merged
wing328 merged 3 commits intoOpenAPITools:php-nextgenfrom Mar 13, 2023
Merged
[php-nextgen] Set minimal PHP version to ^8.0#14500wing328 merged 3 commits intoOpenAPITools:php-nextgenfrom
wing328 merged 3 commits intoOpenAPITools:php-nextgenfrom
Conversation
Member
|
let's do it ! |
|
Why this feature is not in the beta7.0 branch? is there a way to use this branch (php-nexthen). Thanks |
wing328
added a commit
that referenced
this pull request
Sep 3, 2023
* php-nextgen first commit * [php] Set minimal PHP version to ^8.0 (#14500) * Set minimal PHP version to ^8.0 * Fix php-nextgen config * Change stability to BETA * Add phplint package (#15054) * [php-nextgen] Rename folders to follow PDS skeleton (#15102) * Change lib -> src, test -> tests folder This will make build compliant to PHP-PDS skeleton. Ref: https://github.com/php-pds/skeleton * Refresh samples * Exclude composer.lock from codebase (#15105) Since client generator is library and not a project it makes sense to exclude composer.lock from codebase by default. Ref: http://getcomposer.org/doc/02-libraries.md#lock-file * Add @generated tag to DocBlocks (#15106) This tag in draft status right now(PSR-19), but I think we can leverage from it already. Ref: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-generated * update samples, doc * update samples --------- Co-authored-by: Yuriy Belenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would even set PHP ^8.1 since it has new key features like union of types
public setTarget(SomeClass | AnotherClass $target)which is very handy to use from the first day. It could also reduce maintain burden(support one version instead of two). But I assume that community wants to cover all current PHP version, so be it"php": ^8.0.Related #14152
In the next PR I'm gonna add
strict_typesdeclaration and extendPHP-CS-Fixerconfig a lot. It can cause huge PR with huge diffs because it obviously will update code style in all samples.Also want to add
phplintpackage for quick syntax check and CI.Then long refactoring discussed with @wing328. William wants to port
fromJson,toJson,toDict,fromDictmethods frompython-nextgenand hide data serialization in ApiClient then user don't need to be aware of ObjectSerializer anymore. My personal goal is to use new PHP features. Second goal is to use interfaces as much as possible, to be more specific I want new php client to be easy configurable via PHP-DI container. Maybe we finally can stop depending on GuzzleClient and use PSR HttpClient interface instead.I didn't check generated TravisCI config since I don't use it anymore(I like GitHub Actions more recently), but their online compiler says that syntax is correct.
cc @Articus @jebentier @dkarlovi @mandrean @jfastnacht @renepardon
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)