Skip to content

[Java][Client] Generate servers for okhttp-gson#14179

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
outscale-mdr:server_okhttp
Dec 17, 2022
Merged

[Java][Client] Generate servers for okhttp-gson#14179
wing328 merged 2 commits intoOpenAPITools:masterfrom
outscale-mdr:server_okhttp

Conversation

@outscale-mdr
Copy link
Copy Markdown
Contributor

@outscale-mdr outscale-mdr commented Dec 5, 2022 •
edited
Loading

This PR is to support servers variables in okhttp-json, this is an addon of #4998 because it was missing the okhttp-gson.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@outscale-mdr outscale-mdr marked this pull request as ready for review December 5, 2022 14:21
@outscale-mdr
Copy link
Copy Markdown
Contributor Author

outscale-mdr commented Dec 5, 2022 •
edited
Loading

Can you restart CircleCi pipeline, it fails because it did not have oAuth authorization and the "rerun" button is disable for my user ?

@outscale-mdr
Copy link
Copy Markdown
Contributor Author

outscale-mdr commented Dec 6, 2022

Thank you @borsch , can you restart circle-ci pipeline ?

@borsch
Copy link
Copy Markdown
Member

borsch commented Dec 7, 2022

Thank you @borsch , can you restart circle-ci pipeline ?

Nope, I don't have such permissions. You can either
a) merge master & push changes again
b) or just close and re-open same pull request again. this will re-trigger pipelines

@outscale-mdr
Copy link
Copy Markdown
Contributor Author

outscale-mdr commented Dec 8, 2022

@borsch, Can we merge ? Node1 seems to fail for a lot of PR

@borsch
Copy link
Copy Markdown
Member

borsch commented Dec 8, 2022

@borsch, Can we merge ? Node1 seems to fail for a lot of PR

I don't have write permissions. ask somebody from core team https://github.com/openapitools/openapi-generator/#61---openapi-generator-core-team

@outscale-mdr
Copy link
Copy Markdown
Contributor Author

outscale-mdr commented Dec 8, 2022

cc @wing328 @jimschubert @cbornet @jmini @etherealjoy @spacether

@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 17, 2022

LGTM. Thanks for the PR.

@wing328 wing328 merged commit 9450984 into OpenAPITools:master Dec 17, 2022
@wing328 wing328 added this to the 6.3.0 milestone Jan 20, 2023
@adrian-haenni adrian-haenni mentioned this pull request Aug 28, 2023
Open
6 tasks
@rgcv rgcv mentioned this pull request Aug 5, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borsch borsch borsch approved these changes

Assignees

No one assigned

Labels

Client: Java Enhancement: General

Projects

None yet

Milestone

6.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@outscale-mdr @borsch @wing328