Skip to content

Fix enum generation for php-symfony generator#14105

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
tahiti-web-design:fix/symfony-enum
Dec 27, 2022
Merged

Fix enum generation for php-symfony generator#14105
wing328 merged 2 commits intoOpenAPITools:masterfrom
tahiti-web-design:fix/symfony-enum

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 24, 2022

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

Currently, the model generic template is used to generate all DTO classes including enums.
This results in empty classes for enums.

This PR just make use of the existing model enum template to generate enum DTOs.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 25, 2022

@renaud-twd thanks for the PR. Can you please merge the latest master (which includes #14117 with a test for enum model) into your branch?

@ghost ghost force-pushed the fix/symfony-enum branch from 690947a to 8696bf1 Compare November 28, 2022 20:52
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 28, 2022

@wing328 thanks for the feedback.
I rebased on top of the latest master (which includes #14117).
I also regenerated samples and docs.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 26, 2022

hello @wing328,
is there anything else preventing this PR to be merged ?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 27, 2022

Nope. Looks good. Sorry for the delay and thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants