Add file post-processing to Kotlin generators#1400
Merged
Conversation
This was referenced Nov 8, 2018
Contributor
|
This is cool. |
Member
Author
|
@guenhter very good question. At the moment, we don't do that because not all contributors (new or existing) have |
Contributor
|
Ok, but this PR is then already great because we have the possibility to add klint. |
Contributor
|
This is very useful indeed 👍 |
Member
Author
|
Thanks for reviewing. Merged it to master. There's a minor issue with 2 files in the Kotlin cllient due to wildcard import: #1401 If anyone has time, please help fix it with a PR. Thanks. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* add post processing to kotlin file * restore kotlin samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
--enable-post-process-fileusing CLI)3ca2aa8#diff-ed802784b178ca4a654ed7828c5eb0b8 shows the auto-format code done by
ktlintcc @jimschubert (2017/09) @dr4ke616 (2018/08)