Closed
Conversation
added 8 commits
November 7, 2018 17:43
…e option. Add unit test.
…illis() on Linux.
Contributor
|
Thanks! Sometimes I get tripped up by gitflow. |
3 tasks
ackintosh
reviewed
Nov 13, 2018
|
|
||
| /** | ||
| * Write bytes to a file | ||
| * @param filename The name of file to write |
Contributor
There was a problem hiding this comment.
[nits] Please insert blank comment line between the description and the list of tags.
ackintosh
reviewed
Nov 13, 2018
|
|
||
| /** | ||
| * Is the minimal-file-update option enabled? | ||
| * @return Option value |
Contributor
There was a problem hiding this comment.
[nits] Please insert blank comment line between the description and the list of tags.
| @SuppressWarnings("static-method") | ||
| /** | ||
| * Write String to a file, formatting as UTF-8 | ||
| * @param filename The name of file to write |
Contributor
There was a problem hiding this comment.
[nits] Please insert blank comment line between the description and the list of tags.
* Add blank comment lines to satisfy PR feedback * Remove tabs
Contributor
|
I've resolved the conflicts. 938e34a 😌 |
ackintosh
approved these changes
Nov 30, 2018
jimschubert
approved these changes
Mar 13, 2019
Member
jimschubert
left a comment
jimschubert
left a comment
There was a problem hiding this comment.
This looks good, but needs to integrate master to resolve merge conflicts.
3 tasks
Contributor
|
This PR can be closed? (#2451 has been merged) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Cherry-picks comments from #1391
Credits go to @wheezil
Also cc @OpenAPITools/generator-core-team