Skip to content

[GO] fix identation for model_simple.mustache#13919

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
gssbzn:patch-1
Nov 5, 2022
Merged

[GO] fix identation for model_simple.mustache#13919
wing328 merged 2 commits intoOpenAPITools:masterfrom
gssbzn:patch-1

Conversation

@gssbzn
Copy link
Copy Markdown
Contributor

@gssbzn gssbzn commented Nov 4, 2022

This corrects the indentation for recent changes in #13843

#13843 used spaces for indentation which causes the generated code to have the incorrect space for go which should uses tab

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@gssbzn
Copy link
Copy Markdown
Contributor Author

gssbzn commented Nov 4, 2022

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 5, 2022

thanks for the fix, which looks good to me.

@wing328 wing328 merged commit d5f896f into OpenAPITools:master Nov 5, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 7, 2022

FYI. I've filed #13940 as a follow-up PR to regenerate tests and replace more 4-space with tabs.

@gssbzn gssbzn deleted the patch-1 branch November 7, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants