Skip to content

12551 marshal readonly fields#13875

Closed
gcatanese wants to merge 2 commits intoOpenAPITools:masterfrom
gcatanese:12551-marshal-readonly-fields
Closed

12551 marshal readonly fields#13875
gcatanese wants to merge 2 commits intoOpenAPITools:masterfrom
gcatanese:12551-marshal-readonly-fields

Conversation

@gcatanese
Copy link
Copy Markdown
Contributor

@gcatanese gcatanese commented Nov 1, 2022 •
edited
Loading

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

Readonly fields to be ignored during toSerialize

PR checklist

  • [x ] Read the contribution guidelines.
  • [x ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x ] Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 28, 2022

@gcatanese can you please resolve the merge conflicts when you've time?

wing328
wing328 reviewed Dec 28, 2022
View reviewed changes
Comment thread modules/openapi-generator/src/main/resources/go/model_simple.mustache
}
{{/isReadOnly}}
{{#isReadOnly}}
// skip: {{baseName}} is readOnly
Copy link
Copy Markdown
Member

@wing328 wing328 Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use tab instead of spaces

wing328
wing328 reviewed Dec 28, 2022
View reviewed changes
Comment thread samples/client/petstore/go/go-petstore/model_name.go
// skip: 123Number is readOnly
return json.Marshal(toSerialize)
}

Copy link
Copy Markdown
Member

@wing328 wing328 Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test with model_name to ensure readonly fields are not serialized?

Copy link
Copy Markdown
Contributor Author

@gcatanese gcatanese Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 I have added already a test in GoClientCodegenTest, but I think you are asking to add a different test. Can you point me to the right direction (what/where to change)? Tnx

@gcatanese
Copy link
Copy Markdown
Contributor Author

gcatanese commented Dec 28, 2022

I am going to re-create the branch (my branch is many changes behind master) to make it easier/clear

@gcatanese gcatanese closed this Dec 28, 2022
@gcatanese gcatanese deleted the 12551-marshal-readonly-fields branch December 28, 2022 11:38
@gcatanese gcatanese mentioned this pull request Dec 28, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328 wing328 wing328 left review comments

Assignees

No one assigned

Labels

Client: Go Issue: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gcatanese @wing328