[cpp-pistache]Add support for map#1359
Merged
etherealjoy merged 2 commits intoOpenAPITools:masterfrom Nov 3, 2018
Merged
Conversation
Add support for nested maps Simply Array and Map Helper
Contributor
|
Shouldn't map support be handled at the AbstractCppCodegen level? |
Contributor
Author
|
Unfortunately this is mustache only change so related only to |
stkrwork
requested changes
Nov 2, 2018
Contributor
Author
|
@stkrwork |
stkrwork
approved these changes
Nov 3, 2018
Contributor
stkrwork
left a comment
stkrwork
left a comment
There was a problem hiding this comment.
i tend to use type const& name, but this is also fine.
Contributor
Author
|
Many thanks for the review. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Add support for map * Add support for nested maps * Simplify Array and Map Helper * Use const reference wherever possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Add support for map
Add support for nested maps
Simplify Array and Map Helper
Fixes #745
@stkrwork @MartinDelille @fvarose @ravinikam