Fix defaultValue for String schema in Dart#1342
Fix defaultValue for String schema in Dart#1342wing328 merged 1 commit intoOpenAPITools:masterfrom nzigen:fix-dart-default-string
Conversation
|
@ysawa thanks for the fix, which looks good to me. If no further feedback or question, I'll merge it tomorrow (Thursday) |
|
@wing328 thanks for your review. I am looking forward to the merge. |
|
@ysawa PR merged into master. Thanks for your contribution. Do you mind filing the same fix for Dart Jaguar client generator: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartJaguarClientCodegen.java#L64 ? cc @jaumard |
|
@ysawa thanks again for the PR, which has been included in the v3.3.3 release: https://twitter.com/oas_generator/status/1062929948191510528 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Output
defaultValuevalue for String is unquoted and it will cause syntax errors in Dart.Markdown outputs is like:
and,
**description** | **String** | | [optional] [default to ""]may be better.Also, generated Dart code is as below:
, and this should be
String description = "";.I hope it will be fixed.
@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)