Skip to content

Add group parameter support to PHP client#1337

Merged
wing328 merged 12 commits intomasterfrom
php-group-parameter
Oct 29, 2018
Merged

Add group parameter support to PHP client#1337
wing328 merged 12 commits intomasterfrom
php-group-parameter

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Oct 28, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For #641

Add group parameter support via x-group-parameters

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko

@wing328 wing328 merged commit aced89f into master Oct 29, 2018
@wing328 wing328 deleted the php-group-parameter branch October 29, 2018 07:42
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* add group parameter support to php template

* more update for group parameter

* fix call to protect function

* fix missing $

* update based on feedback

* create fake endpoint to test group parameters

* sync fake petstore spec v2, v3

* fix php doc for group parameters

* update petstore samples

* update fake petstore spec v2

* update petstore samples

* fix spec and update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant