Skip to content

Fix W605 warning and reenable flake8#1334

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
micw523:master
Oct 28, 2018
Merged

Fix W605 warning and reenable flake8#1334
wing328 merged 1 commit intoOpenAPITools:masterfrom
micw523:master

Conversation

@micw523
Copy link
Copy Markdown
Contributor

@micw523 micw523 commented Oct 27, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes #1307. Am testing the Travis CI build now and will remove [WIP] tag when Travis CI build is done.

@micw523 micw523 changed the title [WIP] Fix W605 warning and reenable flake8 Fix W605 warning and reenable flake8 Oct 27, 2018
@micw523
Copy link
Copy Markdown
Contributor Author

micw523 commented Oct 27, 2018

Clear. Copying technical committee @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 27, 2018

@micw523 thanks for the fix, which looks good to me 👍

@tomplus
Copy link
Copy Markdown
Member

tomplus commented Oct 27, 2018

LGTM

@wing328 wing328 merged commit 1074674 into OpenAPITools:master Oct 28, 2018
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 31, 2018

@micw523 thanks for the PR, which is included in the v3.3.2 release: https://twitter.com/oas_generator/status/1057649626101112832

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python tests failed in Travis CI

3 participants