[Erlang][Server] Add two options: packageName and openAPISpecName #1303
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Oct 24, 2018
feihongmeilian:master
Merged
[Erlang][Server] Add two options: packageName and openAPISpecName #1303wing328 merged 3 commits intoOpenAPITools:masterfrom feihongmeilian:master
wing328 merged 3 commits intoOpenAPITools:masterfrom
feihongmeilian:master
Conversation
Member
|
@feihongmeilian the change looks good to me. cc @tsloughter |
wing328
reviewed
Oct 24, 2018
| get_openapi_path() -> | ||
| {ok, AppName} = application:get_application(?MODULE), | ||
| filename:join({{packageName}}_utils:priv_dir(AppName), "openapi.json"). | ||
| filename:join({{packageName}}_utils:priv_dir(AppName), "{{openAPISpecName}}.json"). |
Member
There was a problem hiding this comment.
Please use {{{openAPISpecName}}} instead to obtain the original value.
wing328
approved these changes
Oct 24, 2018
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
LGTM (the Travis CI failure is not related to this PR)
wing328
changed the title
Member
|
@feihongmeilian thanks for the PR, which is included in the v3.3.2 release: https://twitter.com/oas_generator/status/1057649626101112832 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…penAPITools#1303) * Implement the ability to read packageName and openAPISpecName from a json file * Replace '{{openAPISpecName}}' with '{{{openAPISpecName}}}' * Update erlang-petstore-server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packageName : Specify the prefix to the erl file that generate by openapi-generator.
openAPISpecName : Specify the json file name generated by yaml file