[cpp rest-sdk] Improve method signatures to use const when the value won't change#1295
Merged
etherealjoy merged 4 commits intoOpenAPITools:masterfrom Oct 28, 2018
Merged
[cpp rest-sdk] Improve method signatures to use const when the value won't change#1295etherealjoy merged 4 commits intoOpenAPITools:masterfrom
etherealjoy merged 4 commits intoOpenAPITools:masterfrom
Conversation
etherealjoy
requested changes
Oct 23, 2018
stkrwork
approved these changes
Oct 23, 2018
Contributor
|
I think it is a little complicated with Models, being passed a a shared_ptr. |
etherealjoy
approved these changes
Oct 23, 2018
wing328
changed the title
Member
|
@whoan thanks for the PR, which is included in the v3.3.2 release: https://twitter.com/oas_generator/status/1057649626101112832 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Improve method signatures to use const when the value won't change * Update PetStore * Change setters for non-primitive types to receive const reference parameters * Update PetStore
This was referenced Jul 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Improve method signatures to use const when the value won't change.
Ping @ravinikam @stkrwork @fvarose @etherealjoy @MartinDelille