Skip to content

[csharp-netcore] fix NPE when handling custom Content-type#12836

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
the-akhil-nair:custom_content_issue
Jul 12, 2022
Merged

[csharp-netcore] fix NPE when handling custom Content-type#12836
wing328 merged 1 commit intoOpenAPITools:masterfrom
the-akhil-nair:custom_content_issue

Conversation

@the-akhil-nair
Copy link
Copy Markdown
Contributor

Fix #12835

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

This PR will fix issue: OpenAPITools#12835

Signed-off-by: the-akhil-nair <[email protected]>
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 11, 2022

@the-akhil-nair thanks for the PR.

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 6.1.0 milestone Jul 11, 2022
@wing328 wing328 changed the title [custom_content_issue] [csharp-netcore] fix NPE when handling custom Content-type Jul 12, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 12, 2022

Tested to confirm the fix. I'll submit another PR to further improve it (e.g. tests, etc)

@wing328 wing328 merged commit 6dfbc58 into OpenAPITools:master Jul 12, 2022
@wing328 wing328 mentioned this pull request Jul 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Csharp-Netcore] Handle custom Content-type issue

2 participants