[java][retrofit2] Fix: Always set jakarta_annotation_version#12834
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jul 13, 2022
Merged
[java][retrofit2] Fix: Always set jakarta_annotation_version#12834wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
@edwardmp thanks for the PR. Can you please follow step 3 in the PR checklist to update the samples? |
Commit 1735ab9 added changes to set the `jakarta_annotation_version`. I've recently noticed that when using retrofit2 library, the project builds fine with Maven but fails with Gradle. The build fails due to `Could not get unknown property 'jakarta_annotation_version' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler`. Digging into this, in the generated `build.gradle` the `jakarta_annotation_version` is never set. Upon closer inspection, aforementioned commit seems to indeed set it differently for the Maven build configuration than the Gradle build configuration (same for SBT configuration) for that matter. The issue is that due to human error the `jakarta_annotation_version` line is added within the `{{#usePlayWS}}` block, meaning it won't be generated when `usePlayWS` is false, even though it should. This commit changes this to always generate it.
Contributor
Author
|
@wing328 whoops my bad. Done, commit updated! |
Member
|
Tested locally and the result is good Will try to setup CI to catch the issue moving forward. |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1735ab9 added changes to set the
jakarta_annotation_version.I've recently noticed that when using retrofit2 library, the project builds fine with Maven but fails with Gradle.
The build fails due to
Could not get unknown property 'jakarta_annotation_version' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.Digging into this, in the generated
build.gradlethejakarta_annotation_versionis never set.Upon closer inspection, aforementioned commit seems to indeed set it differently for the Maven build configuration than the Gradle build configuration (same for SBT configuration) for that matter.
The issue is that due to human error the
jakarta_annotation_versionline is added within the{{#usePlayWS}}block, meaning it won't be generated whenusePlayWSis false, even though it should.This commit changes this to always generate it.
E.g. before applying this commit
build.gradlelooks like:After applying the change:
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)