Skip to content

Resolve language generator ambiguities#12808

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
mmiikkkkaa:resolve-language-generator-ambiguities
Jul 9, 2022
Merged

Resolve language generator ambiguities#12808
wing328 merged 2 commits intoOpenAPITools:masterfrom
mmiikkkkaa:resolve-language-generator-ambiguities

Conversation

@mmiikkkkaa
Copy link
Copy Markdown
Contributor

Since now "generatorName" is used instead of "language" to specifying what will be generated, some parts of the description were corrected, which were still using "language" instead of "generator". No code changes.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Since now "generatorName" is used instead of "language" to specifying what will be generated, some parts of the description were corrected, which were still using "language" instead of "generator".
@mmiikkkkaa mmiikkkkaa requested a review from jimschubert as a code owner July 8, 2022 15:48
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 9, 2022

LGTM. Thanks for the PR.

@wing328 wing328 merged commit d364daa into OpenAPITools:master Jul 9, 2022
@wing328 wing328 added this to the 6.1.0 milestone Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants