Skip import of allOf composition schema#12798
Merged
Conversation
5 tasks
mugioka
added a commit
to mugioka/openapi-generator
that referenced
this pull request
Oct 4, 2022
…lName).
Hi team.
The following error occurred while generating a k6 scenario from oas using openapi-generator-cli version 6.2.0.
```log
Exception in thread "main" java.lang.RuntimeException: Could not process model 'CommonSiteLink'.Please make sure that your schema is correct!
at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:518)
at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:912)
at org.openapitools.codegen.cmd.Generate.execute(Generate.java:465)
at org.openapitools.codegen.cmd.OpenApiGeneratorCommand.run(OpenApiGeneratorCommand.java:32)
at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:66)
Caused by: java.lang.NullPointerException: Cannot invoke "io.swagger.v3.oas.models.media.Schema.getDiscriminator()" because "childSchema" is null
at org.openapitools.codegen.DefaultCodegen.addImport(DefaultCodegen.java:5497)
at org.openapitools.codegen.DefaultCodegen.updateModelForComposedSchema(DefaultCodegen.java:2633)
at org.openapitools.codegen.DefaultCodegen.fromModel(DefaultCodegen.java:2963)
at org.openapitools.codegen.DefaultGenerator.processModels(DefaultGenerator.java:1291)
at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:513)
... 4 more
```
This error is occurred if allDefinitions is null or
allDefinitions.get(ref) returned null.
Therefore i added null check of childSchema to if statement.
This error was generated by OpenAPITools#12798.
The release that incorporates this PR appears to be 6.1.0, so versions above 6.1.0 may have the above error.
Signed-off-by: mugioka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip import of allOf composition schema (without discriminator)
Only javascript, python generator keeps the old behaviour.
FYI @OpenAPITools/generator-core-team
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)