Skip to content

[JavaScript] Fix duplicated superclass constructor calls#1270

Merged
wing328 merged 1 commit intomasterfrom
fix_duplicate_call_js
Oct 26, 2018
Merged

[JavaScript] Fix duplicated superclass constructor calls#1270
wing328 merged 1 commit intomasterfrom
fix_duplicate_call_js

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Oct 19, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #1216

cc @CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Oct 26, 2018

Given that the tests passed and the duplicated lines have been removed, I'll merge it into master.

@wing328 wing328 merged commit 3b53ac4 into master Oct 26, 2018
@wing328 wing328 deleted the fix_duplicate_call_js branch October 26, 2018 10:28
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JavaScript] Duplicate superclass constructor calls

1 participant