Skip to content

[R] Add support to download response as files#12373

Merged
wing328 merged 1 commit intomasterfrom
r_save_file
May 17, 2022
Merged

[R] Add support to download response as files#12373
wing328 merged 1 commit intomasterfrom
r_save_file

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 15, 2022

  • Added optional method argument "data_file" to methods that return data in order to support downloading the response body as files.
  • Added test cases and tested locally.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @Ramanth (2019/07) @saigiridhar21 (2019/07)

@wing328 wing328 added this to the 6.0.0 milestone May 15, 2022
@wing328 wing328 merged commit 040482e into master May 17, 2022
@wing328 wing328 deleted the r_save_file branch May 17, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant