Skip to content

[php] Bump required PHP version to 7.4#12359

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
ybelenko:11038_php_client
May 15, 2022
Merged

[php] Bump required PHP version to 7.4#12359
wing328 merged 2 commits intoOpenAPITools:masterfrom
ybelenko:11038_php_client

Conversation

@ybelenko
Copy link
Copy Markdown
Contributor

Didn't test it locally since it's one line of code change in Composer definitions.
Related #11038

cc @jebentier @dkarlovi @mandrean @jfastnacht @renepardon

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented May 15, 2022

👌 Let's see if Travis CI catches anything after the merge.

@wing328 wing328 merged commit 023f4e7 into OpenAPITools:master May 15, 2022
@wing328 wing328 added this to the 6.0.0 milestone May 15, 2022
@ybelenko ybelenko deleted the 11038_php_client branch May 15, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants