Playframework oauth small upgrade#12332
Merged
wing328 merged 20 commits intoOpenAPITools:masterfrom May 11, 2022
Merged
Conversation
Sync with latest openapi master
merge latest openapi
Merge openapi master
merge master
merge original
merge master
merge master
merge master
Surefire fix
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
bflamand
commented
May 10, 2022
| Algorithm algorithm = Algorithm.RSA256((RSAPublicKey) publicKey, null); | ||
| tokenVerifier = JWT.require(algorithm) | ||
| .withIssuer(issuer) | ||
| .acceptLeeway(leeway) |
Contributor
Author
There was a problem hiding this comment.
this is required in some circumstances to tolerate some clock synchronization issues between backends and oauth authentification server. Configurable by the application to the desired value, default 3 sec.
This is the only thing that is changed by this pull request.
JFCote
approved these changes
May 10, 2022
Member
|
Thanks again for the PR, which has been included in the v6.0.0 release: https://twitter.com/oas_generator/status/1529669733934841856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)