Add martindelille to code owners#12328
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom May 10, 2022
Merged
Conversation
Contributor
Author
|
ping @generator-core-team @jimschubert @openapitools/generator-core-team @wing328 |
Member
|
OK. Let's give it a try 👍 |
sorin-florea
added a commit
to sorin-florea/openapi-generator
that referenced
this pull request
May 10, 2022
…-param-explode * origin/master: Add martindelille to code owners (OpenAPITools#12328) add tests to set httpUserAgent in r client (OpenAPITools#12321) better error messages for oneOf in java okhttp-gson (OpenAPITools#12311) [Inline model resolver] various improvements (OpenAPITools#12293)
Contributor
Author
|
It won't work since codeowners need write access. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered the github code owner feature that could be useful to improve the review process which is currently done by manually pinging the language team.
If I understand correctly, this changes should automatically ping me when the path mentioned in the CODEOWNERS file are modified in a PR.
I of course don't claim any ownership here but just want to improve the review process. If it seems suitable we could extends this to other contributors.
It would close a preview try to simplify review project (close #10623).
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.