Skip to content

Add new method to detect self-referencing in ModelUtils#12294

Merged
wing328 merged 3 commits intomasterfrom
fix-unalias
May 5, 2022
Merged

Add new method to detect self-referencing in ModelUtils#12294
wing328 merged 3 commits intomasterfrom
fix-unalias

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 4, 2022

  • Add new method to detect self-refernecing in ModelUtils
  • Add tests

(self referencing is already tested by crashSwift5ExampleCodeGenerationStackOverflowTest and crashSwift5ExampleCodeGenerationStackOverflowBug_2Test)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @OpenAPITools/generator-core-team

@wing328 wing328 changed the title Fix unaliasing object schema in ModelUtils Add new method to detect self-refernecing in ModelUtils May 5, 2022
@wing328 wing328 marked this pull request as ready for review May 5, 2022 07:56
@wing328 wing328 changed the title Add new method to detect self-refernecing in ModelUtils Add new method to detect self-referencing in ModelUtils May 5, 2022
@wing328 wing328 added this to the 6.0.0 milestone May 5, 2022
@wing328
Copy link
Copy Markdown
Member Author

wing328 commented May 5, 2022

CircleCI node 2 failure not related to this change.

@wing328 wing328 merged commit d97c152 into master May 5, 2022
@wing328 wing328 deleted the fix-unalias branch May 5, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant