Skip to content

[Typescript] add repository field to package.json#12292

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
witem:feat/typescript-repository-add
May 16, 2022
Merged

[Typescript] add repository field to package.json#12292
macjohnny merged 1 commit intoOpenAPITools:masterfrom
witem:feat/typescript-repository-add

Conversation

@witem
Copy link
Copy Markdown
Contributor

@witem witem commented May 3, 2022

Added repository field to package.json files related to typescript generators. Because for cases when we want to release generated client in a private repository these fields are required for GitHub Actions.
Error without repository field:

npm notice Publishing to https://npm.pkg.github.com/
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://npm.pkg.github.com/@some-company%2fsome-repo - The expected resource was not found.
npm ERR! 404 
npm ERR! 404  '@some-company/[email protected]' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-05-03T13_34_15_254Z-debug-0.log

Recommendation: https://stackoverflow.com/a/61021072

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Please review this PR: @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

@witem
Copy link
Copy Markdown
Contributor Author

witem commented May 10, 2022

Resolve #12333

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution

@macjohnny macjohnny merged commit 5221ca2 into OpenAPITools:master May 16, 2022
@wing328 wing328 added this to the 6.0.0 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants