Skip to content

Move Feign Client url parameter under condition.#12250

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
eugenealeinikov:feign-client-url-param-under-condition
May 6, 2022
Merged

Move Feign Client url parameter under condition.#12250
wing328 merged 1 commit intoOpenAPITools:masterfrom
eugenealeinikov:feign-client-url-param-under-condition

Conversation

@eugenealeinikov
Copy link
Copy Markdown
Contributor

@eugenealeinikov eugenealeinikov commented Apr 27, 2022 •
edited
Loading

Feign Client url parameter moved under condition.
Added additional property 'useFeignClientUrl' that is used in
/src/main/resources/JavaSpring/libraries/spring-cloud/apiClient.mustache. True by default.

Related issue: #4525

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 30, 2022 •
edited
Loading

Thanks for the PR.

cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02)

@eugenealeinikov
Copy link
Copy Markdown
Contributor Author

eugenealeinikov commented May 6, 2022

Please review

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @banlevente (2022/02)

@wing328 wing328 added this to the 6.0.0 milestone May 6, 2022
@wing328 wing328 merged commit 1cca865 into OpenAPITools:master May 6, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented May 6, 2022

@eugenealeinikov thanks for the PR, which has been merged into the master.

@eugenealeinikov eugenealeinikov deleted the feign-client-url-param-under-condition branch May 6, 2022 16:15
@eugenealeinikov
Copy link
Copy Markdown
Contributor Author

eugenealeinikov commented May 6, 2022

@wing328 thanks. When is the next release?

@YevgenyDrozdov YevgenyDrozdov mentioned this pull request Oct 17, 2022
Merged
5 tasks
@cachescrubber cachescrubber mentioned this pull request Oct 27, 2022
Merged
2 tasks
cachescrubber added a commit to cachescrubber/openapi-generator that referenced this pull request Oct 27, 2022
@cachescrubber
Restore OpenAPITools#12250: Move Feign Client url parameter under con…
0f343f4 
…dition.
wing328 pushed a commit that referenced this pull request Nov 1, 2022
@cachescrubber
Spring request mapping mode (#13838)
b54299f 
* Introduce RequestMappingMode option

* generate docs

* Add test case using interfaceOnly

* Generate Samples

* Add requestMappingMode: iface to bin/configs/spring-boot-oas3.yaml

* Restore #12250: Move Feign Client url parameter under condition.

* Rename iface to api_interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borsch borsch borsch approved these changes

Assignees

No one assigned

Labels

Enhancement: Feature Server: Spring

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eugenealeinikov @wing328 @borsch