[Bug][Kotlin-client] Can now handle path param of type list#12244
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom May 4, 2022
Merged
Conversation
sjoblomj
commented
Apr 26, 2022
Comment on lines
55
to
61
Contributor
Author
There was a problem hiding this comment.
The Kotlin type systems makes sure that the parameters cannot be null. Completely redundant check.
d0af34a to
5a4db53
Compare
974115f to
e6a10c8
Compare
sjoblomj
commented
Apr 27, 2022
Contributor
Author
There was a problem hiding this comment.
jvm-volley refuses to build without android.useAndroidX=true, even if generateRoomModels is false
sjoblomj
commented
Apr 27, 2022
Comment on lines
103
to
105
sjoblomj
commented
Apr 27, 2022
Comment on lines
72
to
65
Contributor
Author
There was a problem hiding this comment.
Bugfix (#7199) to handle that you can't use toString() on lists
sjoblomj
commented
Apr 27, 2022
Comment on lines
75
to
70
Contributor
Author
There was a problem hiding this comment.
Bugfix (#7199) to handle that you can't use toString() on lists
61007cd to
6d51d75
Compare
…volley and multiplatform. Also cleaning up generated code
6d51d75 to
dae5b33
Compare
Member
|
LGTM. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11228 I fixed #7199. However, the fix was only for library okhttp, and it turns out that also volley and multiplatform suffer from the same problem. This PR fixes this bug.
The PR also contains some cleaning up of the generated code (which is what most of the updated sample files is about).
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328