Skip to content

Better code format for python client#12231

Merged
wing328 merged 1 commit intomasterfrom
python-better-code2
Apr 25, 2022
Merged

Better code format for python client#12231
wing328 merged 1 commit intomasterfrom
python-better-code2

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Apr 25, 2022

A follow-up PR to #12229 to further improve the code format of the python client.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11) @spacether (2019/11) ❤️

@wing328 wing328 added this to the 6.0.0 milestone Apr 25, 2022
@wing328 wing328 merged commit 23ee8fd into master Apr 25, 2022
@wing328 wing328 deleted the python-better-code2 branch April 25, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant