Skip to content

[Java][OkHTTP] Include HTTP response data in ApiException getMessage()#12207

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
panargirakis:panargirakis_okhttp-gson-apiexception-getmessage
Apr 26, 2022
Merged

[Java][OkHTTP] Include HTTP response data in ApiException getMessage()#12207
wing328 merged 5 commits intoOpenAPITools:masterfrom
panargirakis:panargirakis_okhttp-gson-apiexception-getmessage

Conversation

@panargirakis
Copy link
Copy Markdown
Contributor

Addresses #12205

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@panargirakis panargirakis changed the title [Java][OkHTTP] Include HTTP response data in ApiException [Java][OkHTTP] Include HTTP response data in ApiException getMessage() Apr 23, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 24, 2022

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@panargirakis panargirakis force-pushed the panargirakis_okhttp-gson-apiexception-getmessage branch from 92756e3 to bddfd5a Compare April 25, 2022 15:33
@panargirakis
Copy link
Copy Markdown
Contributor Author

@wing328 Thank you, that should be resolved now.

@wing328 wing328 added this to the 6.0.0 milestone Apr 26, 2022
@wing328 wing328 merged commit 981c090 into OpenAPITools:master Apr 26, 2022
@panargirakis panargirakis deleted the panargirakis_okhttp-gson-apiexception-getmessage branch April 26, 2022 03:54
panargirakis added a commit to panargirakis/openapi-generator that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants