[ruby] Allow boolean for discriminator value in oneOf handling#11750
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 1, 2022
ykitamura-mdsol:ruby_boolean_discriminator_value
Merged
[ruby] Allow boolean for discriminator value in oneOf handling#11750wing328 merged 1 commit intoOpenAPITools:masterfrom ykitamura-mdsol:ruby_boolean_discriminator_value
wing328 merged 1 commit intoOpenAPITools:masterfrom
ykitamura-mdsol:ruby_boolean_discriminator_value
Conversation
Member
Yup, very rare...
Your proposed fix works for both string and boolean so I think it's ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This must be a very rare case but we are using a boolean property as discriminator:
The OpenAPI specification says:
So I think we can modify to handle boolean values property for discriminator.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x