Skip to content

[Java] Fix reactor-netty dependency#11747

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
micopiira:master
Mar 1, 2022
Merged

[Java] Fix reactor-netty dependency#11747
wing328 merged 1 commit intoOpenAPITools:masterfrom
micopiira:master

Conversation

@micopiira
Copy link
Copy Markdown
Contributor

The spring-boot-starter-webflux uses
io.projectreactor.netty:reactor-netty-http
dependency so the io.projectreactor.ipc:reactor-netty
is actually not used at all

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 28, 2022

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

The spring-boot-starter-webflux uses
io.projectreactor.netty:reactor-netty-http
dependency so the io.projectreactor.ipc:reactor-netty
is actually not used at all
@micopiira
Copy link
Copy Markdown
Contributor Author

@wing328 Sorry about that, is it okay now?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 1, 2022

Looks good 👍

@wing328 wing328 added this to the 6.0.0 milestone Mar 1, 2022
@wing328 wing328 merged commit 4daead1 into OpenAPITools:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants