Skip to content

[typescript-angular] only support Angular v9+ #11726

Merged
macjohnny merged 4 commits intomasterfrom
typescript-deprecate-old-versions
Feb 26, 2022
Merged

[typescript-angular] only support Angular v9+ #11726
macjohnny merged 4 commits intomasterfrom
typescript-deprecate-old-versions

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Feb 26, 2022

  • only support Angular v9+
  • remove samples, configs, tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the cleanup
Lgtm

@macjohnny macjohnny merged commit 5c673d8 into master Feb 26, 2022
@macjohnny macjohnny deleted the typescript-deprecate-old-versions branch February 26, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants