Skip to content

[typescript-fetch] / #8881: add ESM to npm builds#11720

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
sdoeringNew:issue_8881
Mar 2, 2022
Merged

[typescript-fetch] / #8881: add ESM to npm builds#11720
macjohnny merged 1 commit intoOpenAPITools:masterfrom
sdoeringNew:issue_8881

Conversation

@sdoeringNew
Copy link
Copy Markdown
Contributor

fix #8881

An additional tsconfig.esm.json is added to every generated typescript-fetch code having supportsES6 and npmName.
That will create an additional ECMAScript Module (ESM) to the npm build.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    # ./bin/utils/export_docs_generators.sh # no docs changed
    
  • Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh ./bin/configs/typescript-fetch-*.
  • For Windows users, please run the script in Git BASH. # No Windows user
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

I welcome the technical committee:
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

In case of "supportsES6" an additional tsconfig.esm.json is created. That will add an ECMAScript module to the npm build.
Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for your contribution!

@macjohnny macjohnny merged commit 53c2c66 into OpenAPITools:master Mar 2, 2022
@macjohnny macjohnny added this to the 6.0.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-fetch] Introduce ES2015+ module builds and other improvements

2 participants