[typescript-fetch] / #8881: add ESM to npm builds#11720
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Mar 2, 2022
Merged
[typescript-fetch] / #8881: add ESM to npm builds#11720macjohnny merged 1 commit intoOpenAPITools:masterfrom
macjohnny merged 1 commit intoOpenAPITools:masterfrom
Conversation
In case of "supportsES6" an additional tsconfig.esm.json is created. That will add an ECMAScript module to the npm build.
6 tasks
macjohnny
approved these changes
Mar 2, 2022
Member
macjohnny
left a comment
There was a problem hiding this comment.
LGTM
thanks for your contribution!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8881
An additional
tsconfig.esm.jsonis added to every generated typescript-fetch code havingsupportsES6andnpmName.That will create an additional ECMAScript Module (ESM) to the npm build.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh ./bin/configs/typescript-fetch-*.master(5.3.0),6.0.xI welcome the technical committee:
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov