Skip to content

fix: avoid generic NPE when refering to missing schema#11718

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
tomasbjerre:feature/avoid-generic-np
Feb 26, 2022
Merged

fix: avoid generic NPE when refering to missing schema#11718
wing328 merged 1 commit intoOpenAPITools:masterfrom
tomasbjerre:feature/avoid-generic-np

Conversation

@tomasbjerre
Copy link
Copy Markdown
Contributor

@tomasbjerre tomasbjerre commented Feb 25, 2022 •
edited
Loading

I was getting a generic NPE that I was unable to analyze:

...
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
Caused by: java.lang.NullPointerException
        at org.openapitools.codegen.DefaultCodegen.updateAllModels(DefaultCodegen.java:568)
        at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:497)
        at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:888)
        at org.openapitools.generator.gradle.plugin.tasks.GenerateTask.doWork(GenerateTask.kt:716)
        ... 223 more
...

Here:
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java#L568

This change gives me something to investigate:

...
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
Caused by: java.lang.NullPointerException: _object in {account=class ComposedSchema {
    class Schema {
...

@tomasbjerre tomasbjerre mentioned this pull request Feb 25, 2022
Open
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 26, 2022

cc @OpenAPITools/generator-core-team

@wing328 wing328 merged commit d20a32f into OpenAPITools:master Feb 26, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement: General

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasbjerre @wing328