Skip to content

Fix ClientCertificates in csharp configuration for client generation.#11711

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
paritoshgote-msft:user/pagote/fixcsharpclientcerts
Mar 6, 2022
Merged

Fix ClientCertificates in csharp configuration for client generation.#11711
wing328 merged 1 commit intoOpenAPITools:masterfrom
paritoshgote-msft:user/pagote/fixcsharpclientcerts

Conversation

@paritoshgote-msft
Copy link
Copy Markdown
Contributor

@paritoshgote-msft paritoshgote-msft commented Feb 24, 2022

Fixes the injection of ClientCertificates in Configuration.mustache for csharp netcore and netcore-functions.

ClientCertificates was not being configured properly as part of the csharp client generation. These changes have been tested locally. Original issue link: #6940

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Adding technical committee members:
@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

Fixes the injection of ClientCertificates in Configuration.mustache for csharp netcore and netcore-functions.
@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 6, 2022

LGTM. Will update the samples after merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants