Skip to content

[csharp-netcore] Fixed csharp netcore conditional serialization#11710

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
emajo:fix-csharp-netcore-conditionalserialization
Mar 6, 2022
Merged

[csharp-netcore] Fixed csharp netcore conditional serialization#11710
wing328 merged 1 commit intoOpenAPITools:masterfrom
emajo:fix-csharp-netcore-conditionalserialization

Conversation

@emajo
Copy link
Copy Markdown
Contributor

@emajo emajo commented Feb 24, 2022

@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)

Using the conditional serialization flag with the csharp-netcore generator each of the properties has a correspondent flag property that determines if it has or not to be serialized when the method toJson gets called.
Using the setters of the properties it works as expected, the flags are set as they have to and the serialized json is alright, but if we set the class properties with the constructor, none of the flags gets set to true, so using the toJson method we get an empty json. This solution checks in the constructor if each property is null or not, if it isn’t, the according flag gets set to true.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 6.0.0 milestone Mar 6, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 6, 2022

LGTM. Will update the samples after merging this PR into master.

@wing328 wing328 merged commit 9efda42 into OpenAPITools:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants