Skip to content

[Play Framework] Fix sonarqube warnings / code smells from the generated code.#11702

Merged
wing328 merged 1 commit intomasterfrom
fix-sonarqube-warning-play-framework
Feb 24, 2022
Merged

[Play Framework] Fix sonarqube warnings / code smells from the generated code.#11702
wing328 merged 1 commit intomasterfrom
fix-sonarqube-warning-play-framework

Conversation

@JFCote
Copy link
Copy Markdown
Member

@JFCote JFCote commented Feb 23, 2022

Nothing risky here. Just removed warnings / code smells that were consistently pop in my generated projects that are scanned by SonarQube.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@JFCote JFCote self-assigned this Feb 23, 2022
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Feb 24, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 24, 2022
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 24, 2022

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: Java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants