Skip to content

[swift5][client] remove apiResponseQueue in the clients that don't have any impact#11698

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
4brunu:feature/swift5-cleanup-unused-api-response-queue
Feb 23, 2022
Merged

[swift5][client] remove apiResponseQueue in the clients that don't have any impact#11698
wing328 merged 1 commit intoOpenAPITools:masterfrom
4brunu:feature/swift5-cleanup-unused-api-response-queue

Conversation

@4brunu
Copy link
Copy Markdown
Contributor

@4brunu 4brunu commented Feb 23, 2022

The parameter apiResponseQueue doesn't have any impact in Async/Await, Combine and PromiseKit, so I removed it in that configuration.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@4brunu
Copy link
Copy Markdown
Contributor Author

4brunu commented Feb 23, 2022

CI Failure doesn't seem to be related to this PR.

@wing328 wing328 added Client: Swift Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Feb 23, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 23, 2022
@wing328 wing328 merged commit 266cd5d into OpenAPITools:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Swift Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants